feat(ThemeContextProvider): expose TextPreset size/lineHeight tokens as css vars #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 778a3c4. |
marcoskolodny
commented
Jul 23, 2024
| @@ -0,0 +1,25 @@ | |||
| import {openStoryPage, screen} from '../test-utils'; | |||
|
|
|||
| const SKINS = ['Movistar', 'Vivo-new', 'O2-new'] as const; | |||
There was a problem hiding this comment.
Tested only in these skins because I don't see any value in adding all the possible ones here
pladaria
approved these changes
Jul 23, 2024
atabel
reviewed
Jul 26, 2024
atabel
approved these changes
Jul 30, 2024
tuentisre
pushed a commit
that referenced
this pull request
Aug 1, 2024
# [15.17.0](v15.16.4...v15.17.0) (2024-08-01) ### Bug Fixes * **Chip:** missing data-component-name when closable ([#1191](#1191)) ([e4e284f](e4e284f)) * **Dialogs:** avoid double execution of native dialogs ([#1183](#1183)) ([68c8db7](68c8db7)) * **Select:** onChange was called twice and there was an empty option in iOS ([#1185](#1185)) ([c44b25b](c44b25b)) ### Features * **icons:** New box, High-priority and MMS icons ([#1188](#1188)) ([edff352](edff352)) * **Rows:** a11y update ([#1180](#1180)) ([5f995ad](5f995ad)) * **ThemeContextProvider:** expose TextPreset size/lineHeight tokens as css vars ([#1178](#1178)) ([921eacf](921eacf))
|
🎉 This PR is included in version 15.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link