Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Carousel): Add workaround for zero width webviews. Remount when webview size changes from 0 to any other value #1026

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

pladaria
Copy link
Member

No description provided.

Copy link

github-actions bot commented Feb 14, 2024

Size stats

master this branch diff
Total JS 10.6 MB 10.6 MB +599 B
JS without icons 1.88 MB 1.89 MB +538 B
Lib overhead 49.3 kB 49.3 kB 0 B
Lib overhead (gzip) 13.4 kB 13.4 kB 0 B

Copy link

github-actions bot commented Feb 14, 2024

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Feb 14, 2024

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-c86ip9fi0-tuentisre.vercel.app

Built with commit 2e899a8.
This pull request is being automatically deployed with vercel-action

@pladaria pladaria changed the title Fix(Carousel): Add workaround for zero width webviews. Remount when webview size changes from 0 to any other value fix(Carousel): Add workaround for zero width webviews. Remount when webview size changes from 0 to any other value Feb 14, 2024
Copy link
Collaborator

@atabel atabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to push for a native fix. If Android devs can't find a solution, we may need to release this workaround

@@ -114,7 +114,9 @@ export {
PageBullets,
CarouselContextProvider,
useCarouselContext,
CarouselContextConsummer,
/** @deprecated Contains a typo. Please use CarouselContextConsumer */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:O

@pladaria
Copy link
Member Author

I'd try to push for a native fix. If Android devs can't find a solution, we may need to release this workaround

Android ticket: https://jira.tid.es/browse/ANDROID-14348

As commented in teams, merging this while they investigate

@pladaria pladaria added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit 36ab108 Feb 20, 2024
11 checks passed
@pladaria pladaria deleted the pladaria/WEB-1644_workaround-for-zero-width-webview branch February 20, 2024 09:59
tuentisre pushed a commit that referenced this pull request Feb 20, 2024
# [14.43.0](v14.42.1...v14.43.0) (2024-02-20)

### Bug Fixes

* **Carousel:** Add workaround for zero width webviews. Remount when webview size changes from 0 to any other value ([#1026](#1026)) ([36ab108](36ab108))
* **Select:** options have wrong styling when field is over inverse variant  ([#1024](#1024)) ([fc7849f](fc7849f))
* **SuccessFeebackScreen:** fix content background ([#1021](#1021)) ([dff56b2](dff56b2))

### Features

* **Popover, Tooltip:** refactor components in order to share the same logic between them ([#1014](#1014)) ([a343fbd](a343fbd))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 14.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants