Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Storybook): fix theme default values for stories opened in a new tab #1261

Merged
merged 2 commits into from
Oct 7, 2024
Merged

chore(Storybook): fix theme default values for stories opened in a new tab #1261

merged 2 commits into from
Oct 7, 2024

Conversation

marcoskolodny
Copy link
Collaborator

Issue: Link

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB 0 B
JS without icons 2.02 MB 2.02 MB 0 B
Lib overhead 68.3 kB 68.3 kB 0 B
Lib overhead (gzip) 16.6 kB 16.6 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

marcoskolodny
marcoskolodny commented Oct 4, 2024
View reviewed changes
.storybook/preview.tsx
@@ -63,16 +63,14 @@ const getTheme = (
selectedPlatform?: Platform,
selectedColorScheme?: ColorScheme
): ThemeConfig => {
const skin = selectedSkin ?? MOVISTAR_SKIN;
const platform = selectedPlatform ?? 'desktop';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening a story in a new tab without using any url params for the skin/platform/colorScheme, the platform was being set to desktop as fallback. This is wrong and it should have been fixed when we added the logic to avoid flashes between first and second render in storybook (#1048).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-9m2mri6wl-flows-projects-65bb050e.vercel.app

Built with commit 4da0450.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@marcoskolodny marcoskolodny changed the title chore(Storybook): fix theme default values for stories opend in a new tab chore(Storybook): fix theme default values for stories opened in a new tab Oct 4, 2024
@marcoskolodny marcoskolodny added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit e9e7067 Oct 7, 2024
11 checks passed
@marcoskolodny marcoskolodny deleted the WEB-2064-fix-storybook-theme-defaults branch October 7, 2024 14:25
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pladaria pladaria pladaria approved these changes

@atabel atabel atabel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoskolodny @tuentisre @pladaria @atabel