Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

组件注册 name 一定要是 magic-ui-XX？ #291

Closed
9aoyang opened this issue Aug 18, 2022 · 5 comments · Fixed by #293
Closed

组件注册 name 一定要是 magic-ui-XX？ #291

9aoyang opened this issue Aug 18, 2022 · 5 comments · Fixed by #293
Labels
bug Something isn't working

Comments

@9aoyang
Copy link
Contributor

9aoyang commented Aug 18, 2022

我尝试了不使用 magic-ui-xx 的形式自定义组件，发现仅仅是这个改动就会让组件无法正常使用。另外，我也尝试使用组合式 api 的方式来自定义组件，同样也无法正常渲染，不知道这是目前的组件规范还是说没考虑到？
@jia000
Copy link
Collaborator

jia000 commented Aug 18, 2022

magic-ui-xx，是组件规范，这点是可以做到使用方无感的，这里需要修改一下runtime
composition-api没有name，这点确实没有考虑到；

@jia000 jia000 added the bug Something isn't working label Aug 18, 2022
@9aoyang
Copy link
Contributor Author

9aoyang commented Aug 19, 2022

react 组件也没有 name，但是好像组件可以正常渲染？

@jia000
Copy link
Collaborator

jia000 commented Aug 19, 2022

react的引用方式不一样

@ututuut
Copy link

ututuut commented Aug 19, 2022

还真的是bug，我还测试了好久，期待官方快速修复

@jia000 jia000 mentioned this issue Aug 19, 2022
Merged
jia000 pushed a commit that referenced this issue Aug 19, 2022
@jia000
fix(ui,runtime): 组件注册默认以magic-ui-xx的形式，不再需要在组件中设置name
de38035 
fix #291
@jia000
Copy link
Collaborator

jia000 commented Aug 19, 2022

请升级到1.1.0-beta.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@jia000 @9aoyang @ututuut