Fix issue #503, setPage实现跳转页面 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia000
requested changes
Mar 19, 2024
packages/core/src/App.ts
Outdated
| @@ -204,7 +204,7 @@ class App extends EventEmitter implements AppCore { | |||
| this.page = undefined; | |||
| } | |||
|
|
|||
| super.emit('page-change'); | |||
| super.emit('page-change', id); | |||
There was a problem hiding this comment.
已更改😀
jia000
requested changes
Mar 19, 2024
packages/utils/src/index.ts
Outdated
| } | ||
| const newUrl = url.toString(); | ||
| if (needReload) { | ||
| window.location.href = newUrl; |
packages/utils/src/index.ts
Outdated
| if (needReload) { | ||
| window.location.href = newUrl; | ||
| } else { | ||
| window.history.pushState({ path: url.href }, '', url.href); |
There was a problem hiding this comment.
设置state key 叫 path，为什么值是href？
There was a problem hiding this comment.
是不是不需要state global.history.pushState({ }, '', url); 这样就可以了
There was a problem hiding this comment.
嗯嗯, 是的, 我改一下
jia000
requested changes
Mar 19, 2024
packages/utils/src/index.ts
Outdated
| if (needReload) { | ||
| window.location.href = newUrl; | ||
| } else { | ||
| window.history.pushState({ path: url.href }, '', url.href); |
There was a problem hiding this comment.
是不是不需要state global.history.pushState({ }, '', url); 这样就可以了
jia000
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 #503 问题;
runtime/vue3/playground/App.vue
runtime/vue2/playground/App.vue
packages/core/src/App.ts