Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug and edit doctests for infix_to_prefix_conversion #10259

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Fix bug and edit doctests for infix_to_prefix_conversion #10259

merged 6 commits into from
Oct 11, 2023

Conversation

hollowcrust
Copy link
Contributor

Describe your change:

Fixes #10063 and #10095.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
@hollowcrust hollowcrust mentioned this pull request Oct 11, 2023
Closed
14 tasks
@cclauss
Copy link
Member

cclauss commented Oct 11, 2023

Did the previous pull request have other enhancements?

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@hollowcrust
Copy link
Contributor Author

Yes, I just brought the enhancements from the old PR.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 11, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 11, 2023
cclauss
cclauss approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks massively.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@cclauss cclauss merged commit 672fda9 into TheAlgorithms:master Oct 11, 2023
3 checks passed
@hollowcrust
Copy link
Contributor Author

Thanks a lot for your help as well!

@hollowcrust hollowcrust deleted the patch-2 branch October 11, 2023 14:41
@hollowcrust hollowcrust restored the patch-2 branch October 11, 2023 14:43
@hollowcrust hollowcrust deleted the patch-2 branch October 11, 2023 14:43
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@hollowcrust @pre-commit-ci @sedatguzelsemme
Fix bug and edit doctests for infix_to_prefix_conversion (TheAlgorith…
361f3c6 
…ms#10259)

* Fix bug and edit doctests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add type hints, raiseError and other minor adjustments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Cleaning code

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollowcrust @cclauss