Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doctests to min_cost_string_conversion.py and removed :c specifier #11721

Merged

Conversation

Lonercode
Copy link
Contributor

Describe your change:

I added doctests to the min_cost_string_conversion.py in the strings directory file as part of Hacktoberfest 2024 contributions. I also made a small change to the code by removing the ':c' specifier which made the code fail to run, and seemed necessary only if used on integers for unicode converson, not strings.

This PR contributes to #9943.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 3, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 4, 2024
@tianyizheng02 tianyizheng02 mentioned this pull request Oct 4, 2024
15 tasks
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one unnecessary comment, everything LGTM

strings/min_cost_string_conversion.py Outdated Show resolved Hide resolved
@tianyizheng02
Copy link
Contributor

FYI, the c specifier was already fixed by a different contributor in a previous PR: #11711

I've already merged that PR, but I'll merge your PR as well since your changes build on that PR by adding doctests. This way, both of you get to have a PR approved.

@tianyizheng02 tianyizheng02 merged commit 59ff87d into TheAlgorithms:master Oct 4, 2024
3 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants