feat: add algorithm 95 to find the longest amicable chain #12113
Conversation
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| return total | ||
|
|
||
| def find_longest_amicable_chain(limit): |
There was a problem hiding this comment.
Please provide return type hint for the function: find_longest_amicable_chain. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function find_longest_amicable_chain
Please provide type hint for the parameter: limit
|
|
||
| return min(longest_chain) if longest_chain else None # Return the smallest member of the longest chain | ||
|
|
||
| def solution(): |
There was a problem hiding this comment.
Please provide return type hint for the function: solution. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function solution
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def sum_of_proper_divisors(n): |
There was a problem hiding this comment.
Please provide return type hint for the function: sum_of_proper_divisors. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function sum_of_proper_divisors
Please provide type hint for the parameter: n
Please provide descriptive name for the parameter: n
| return total | ||
|
|
||
|
|
||
| def find_longest_amicable_chain(limit): |
There was a problem hiding this comment.
Please provide return type hint for the function: find_longest_amicable_chain. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function find_longest_amicable_chain
Please provide type hint for the parameter: limit
| ) # Return the smallest member of the longest chain | ||
|
|
||
|
|
||
| def solution(): |
There was a problem hiding this comment.
Please provide return type hint for the function: solution. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function solution
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
|
This PR adds a solution for Project Euler Problem 95, which finds the smallest member of the longest amicable chain under one million. Changes: Implemented find_longest_amicable_chain to calculate amicable chains using proper divisors. |
1 similar comment
|
This PR adds a solution for Project Euler Problem 95, which finds the smallest member of the longest amicable chain under one million. Changes: Implemented find_longest_amicable_chain to calculate amicable chains using proper divisors. |
algorithms-keeper
bot
removed
require descriptive names
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
project_euler/problem_095/sol1.py
Outdated
| """ | ||
|
|
||
| <<<<<<< HEAD | ||
| ======= |
There was a problem hiding this comment.
An error occurred while parsing the file: project_euler/problem_095/sol1.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 15:3.
parser error: error at 14:2: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~
=======
^
algorithms-keeper
bot
added
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def sum_of_proper_divisors(n): |
There was a problem hiding this comment.
Please provide return type hint for the function: sum_of_proper_divisors. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function sum_of_proper_divisors
Please provide type hint for the parameter: n
Please provide descriptive name for the parameter: n
| return total | ||
|
|
||
|
|
||
| def find_longest_amicable_chain(limit): |
There was a problem hiding this comment.
Please provide return type hint for the function: find_longest_amicable_chain. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function find_longest_amicable_chain
Please provide type hint for the parameter: limit
| ) # Return the smallest member of the longest chain | ||
|
|
||
|
|
||
| def solution(): |
There was a problem hiding this comment.
Please provide return type hint for the function: solution. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file project_euler/problem_095/sol1.py, please provide doctest for the function solution
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
tests are failing
Describe your change:
Checklist: