feat: add support for custom step timeout

[lukebjerring]

Add support for passing in a config param, matching the signature of cucumber-js, to set the step
timeout in cypress.

e.g.

Given('a long running step', { timeout: 60000 }, () => { ... });

It is possible to do this by calling cy.then({timeout: 60000}, () => {...}) inside the implementation function, but that's inconsistent with the signature for cucumberjs, which feels more intuitive.

[lgandecki]

Looks good, thanks!

[lgandecki]

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[donaldpipowitch]

It looks like this MR broke TypeScript for us at this line:

https:/TheBrainFamily/cypress-cucumber-preprocessor/pull/385/files#diff-c3cd9d7865893aca768bfb5cecbcfd9bR50

export function defineParameterType(): void;

Is the change in the MR correct? Because we use the following snippet in our code:

import { defineParameterType } from 'cypress-cucumber-preprocessor/steps';
import * as faker from 'faker';

defineParameterType({
  name: 'faker',
  regexp: /.*/,
  transformer(s) {
    return faker.fake(s).replace(/^"|"$/g, '');
  },
});

(As you can see defineParameterType takes 1 argument here.)

[lgandecki]

sorry, you are definitely right. I wonder if it makes sense to keep some of the types here since the types are available here: https:/DefinitelyTyped/DefinitelyTyped/blob/master/types/cypress-cucumber-preprocessor/steps/index.d.ts ?
I'm trying to decide between fixing the types here, or deleting them altogether. Having two sources of truths bothers me though.

[donaldpipowitch]

Thank you for the fast response and trying to solve this.

[lgandecki]

do you have any opinion about the way to move forward with this problem? :)

[donaldpipowitch]

My personal preference would be:

1. Have all types inside cypress-cucumber-preprocessor.
2. Have all types inside @types/cypress-cucumber-preprocessor.
   ....
3. Have a mix :)

[lgandecki]

For now I've updated the types inside the cypress-cucumber-preprocessor, as per your preference. ;-)
Thanks for the report here and sorry it took a bit. Trying to dig out from my busy todolist..

[donaldpipowitch]

Thank you!