Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ES6 Template Literal Syntax in DocStrings causes critical error #415

Closed
ralphsaunders opened this issue Jul 16, 2020 · 1 comment
Closed

Using ES6 Template Literal Syntax in DocStrings causes critical error #415

ralphsaunders opened this issue Jul 16, 2020 · 1 comment
Labels
released

Comments

@ralphsaunders
Copy link
Contributor

ralphsaunders commented Jul 16, 2020 •
edited
Loading

Current behaviour

Crafting a DocString containing ES6 template literal syntax will cause an error in Cypress and block all tests from running.

Desired behaviour

Desired behaviour is that strings containing ES6 template literals are just strings and can be handled as strings in step implementations.

Test code to reproduce

Any .feature definitions with the following DocString will throw an error as Cypress attempts to parse the template literal.

"""
<div>
    <h1>${ article.title }</h1>
</div>
"""

Versions

  • Cypress version: ^3.4.1
  • Preprocessor version: Current
  • Node version: v14.4.0
@ralphsaunders ralphsaunders mentioned this issue Jul 16, 2020
Merged
ralphsaunders referenced this issue in ralphsaunders/cypress-cucumber-preprocessor Jul 18, 2020
@ralphpulselive
fix(loader.js): pass spec as string to createTestsFromFeature fn
83ef60f 
Suggested fix. Unfortunately test case still fails.

re #415
ralphsaunders referenced this issue in ralphsaunders/cypress-cucumber-preprocessor Jul 18, 2020
@ralphsaunders
fix(featuresloader.js): pass spec as string to createTestsFromFeature fn
706da1c 
All test cases now passing

fix #415
lgandecki pushed a commit that referenced this issue Jul 19, 2020
@ralphpulselive @lgandecki
fix(loader.js): pass spec as string to createTestsFromFeature fn
cbe8c6e 
Suggested fix. Unfortunately test case still fails.

re #415
@lgandecki
Copy link
Collaborator

🎉 This issue has been resolved in version 2.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@badeball badeball mentioned this issue Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphsaunders @lgandecki