-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipped Scenarios missing from cucumber.json files #288 #329
Conversation
sorry, I took so long, tough few months for our organization... :) Looks good though! Thanks for the work |
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This has the unforunate consequence of running before- & after-hooks for all skipped tests. If I now mark a test with I'm not sure what the best option here is though. Generating Cucumber reports is already quite a headache. |
damn.. that's definitely not what we want. I guess when you use @Focus in the GUI you don't need the reports though? maybe we could disable it unless someone runs cypress with run instead of open? |
I'm just brainstorming here, but do we need to call |
I'm not sure.. It sounds reasonable. @jcundill ? |
We have another issue here now. We pass our output file to Jira TM4J via the automation end point and we get the result We've added this into TM4J and can manually mark our tests cases as Granted not strictly an issue with this library. |
See the same with Serenity/Cucumber ... seems TM4J endpoint /rest/atm/1.0/automation/execution/cucumber/projectId cannot cope with That seems to be a general problem on TM4J. |
@JuergenKindler I raised #419 about the issue, it seems that TM4J weren't too fussed about fixing it and therefore I wrote a post-processing script which we run after our tests, prior to submission to TM4J, which removes any tests that are fully skipped. |
That's what I was also planning for now. But as soon as I have a way to contact their support, I will push here. |
…solving step definition files Rewrite of getStepDefinitionPaths function to fix various issues and inconsistencies with resolving of step definition files from locations defined in config. BREAKING CHANGE: Users that don't use any workarounds for this issue should be unaffected. But its no longer possible to have stepDefinitions and nonGlobalStepBaseDir simultaneously defined in the config since they are synonymous. fix #329, fix #553
Addresses #288
Currently skipped tests, those not matching the tags used for the run, are not added to the cucumber.json files generated during that run.
This PR adds them back into the generated files.
Changes:
In
createTestsFromFeature
pass all the scenarios intocreateTestFromScenarios
but mark the subset that should actually be executed with ashouldRun
flag.In
createTestFromScenarios
check if the scenario should be executed and if not just add it to thecucumberDataCollector
and tellmocha
that we skipped this test.Fix the
cucumberDataCollector
not to fail the scenario ifmocha
tells it that the test was skipped.