-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrast ratio not updated for certain colour values #287
Comments
Hi Pat, nice to see you around. This issue has been fixed in 0e9a5cb |
@ferllings any chance that could be pushed to a new release then? |
Yes, I was waiting for few things, but I postponed for too long. |
thanks for the release today @ferllings ... confirming that this is now fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Very rarely, there are certain colour combinations that cause a JS error and don't update the contrast ratio calculation
Desktop (please complete the following information):
To Reproduce
Steps to reproduce the behavior:
#000
against#FFF
with a ratio of 21:1#F56E00
into the foreground colour fieldExpected behavior
Contrast ratio to be updated
Screenshots
Animated gif showing how pasting
#F56E00
into foreground dosn't update the calculated contrastAdditional context
Following error is shown in devtools console:
The text was updated successfully, but these errors were encountered: