Support dark mode #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is accomplished using the new `colorStyle` attribute to make the background style transparent. Foreground transparency is also enabled for the default style, which allows TOML keys to be readable in light and dark modes. Fixes #4
Images were captured using Courier New, size 14. The dark screenshot was captured using the Monokai theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Add support for dark mode.
This change does not require separate light and dark versions of the UDL. This is accomplished by making the style backgrounds transparent. In addition, the foreground for default text is transparent so TOML keys render neatly.
Update the light screenshot and add a dark screenshot.
The results can be viewed by browsing the GitHub repo at this branch's current commit.
Fixes #4