Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine into volume with image file should use image as the cover art #1146

Open
eharris opened this issue Jul 5, 2024 · 2 comments
Open

Comments

@eharris
Copy link

eharris commented Jul 5, 2024

Feature request

When I combine a set of files (I have chapters as individual files, and do not have embedded cover art in the audio files), even when I select the jpg image as part of the "Combine" selection, it does not use that image as the cover art.

Narrative

  • Feel free to change the following format to better suit the details of the enhancement

GIVEN:

  • When files are combined
    WHEN:
  • a separate image file is included with the audio files to be combined
    THEN:
  • The image file should be used as the cover art
@GianniCarlo
Copy link
Collaborator

I tested this out with just 3 files, 2 mp3s and 1 jpg and couldn't reproduce the issue. I remember fixing something related to artworks in either the last or previous version, could you help me with the app version you're running?

I did see an issue with autoplay for volumes that have jpg files, where it won't either continue, or go back a chapter when rewinding , I'll get to that soon-ish

@eharris
Copy link
Author

eharris commented Jul 6, 2024

The settings page says 5.3.0-51.
To give more info on my process, I imported a zip file with a directory that contained 15 mp3's and a jpg. I then did a combine of the mp3's and the jpg.
The jpg is shown as the folder icon in the Library, but not the cover art in the player. The player just shows a gradient.
One other interesting note, the jpg file in the Library doesn't get shown as itself, it is also a simple gradient. But the jpg content is getting shown for the containing folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants