Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when percentCompleted is NaN or infinite #972

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Fix crash when percentCompleted is NaN or infinite #972

merged 1 commit into from
Jul 23, 2023

Conversation

GianniCarlo
Copy link
Collaborator

@GianniCarlo GianniCarlo commented Jul 21, 2023 •
edited
Loading

Bugfix

  • Including the percent completed for VoiceOver was making it fail when the percent was not defined (which looks to be a product of a bad migration, as it should default to 0 to any new item or empty folder)

Related tasks

#971

Approach

  • On initialization of SimpleLibraryItem, add a check for the percentCompleted property and assign 0 if it's nil or infinite

@GianniCarlo GianniCarlo self-assigned this Jul 21, 2023
@GianniCarlo GianniCarlo merged commit 298af10 into develop Jul 23, 2023
1 check passed
@GianniCarlo GianniCarlo deleted the fix-crash-nan branch July 23, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo