Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial memory visualizer for Vulkan #128

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Conversation

Jasper-Bekkers
Copy link
Member

This actually does two things;

  • It has an optimization for the callstack resolution which now only happens when it needs to instead of eagerly doing it all the time. This saves significant time in dbghelp.dll and saves some memory too since we only need to store the stack pointers instead of the string
  • It includes a new allocation overview window that is just a flat list of all allocations that are currently being held by the allocator, including their name. This makes it super easy to track down where memory is being wasted.

@Jasper-Bekkers Jasper-Bekkers merged commit a8f4f75 into main Sep 2, 2022
@MarijnS95 MarijnS95 deleted the memory-visualizer branch September 2, 2022 14:43
@Jasper-Bekkers Jasper-Bekkers restored the memory-visualizer branch September 4, 2022 17:59
@Jasper-Bekkers
Copy link
Member Author

@MarijnS95 I restored the branch because this was causing internal build failures; which is why this repo is set not to delete branches when merging in the first place :-)

@MarijnS95
Copy link
Member

IMHO we should reference the main branch more eagerly after merging, or push a tag for as long as this rev needs to stick around, instead of leaving unused branches cluttering up which we don't have as a workflow anywhere else (and this kind of thing happened before, rev references to branches aren't reliable enough).

(Besides, it's quite tricky to get this right in the GitHub app which still jitters the "Load more items" and "Delete merged branch" button around a lot)

Now that the internal revision is updated, can the branch be re-removed? 🥺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants