Remove unused windowing-related dependencies from dev-dependencies
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the `imgui` => `egui` conversion in #176 all window-based examples were removed but none of their dependencies were removed, causing a suspiciously-successful `raw-window-handle 0.6` bump by `dependabot` (#179) despite this being fully incompatible with the current `winit 0.28` release, as well as `ash-window 0.12`. Delete `winit`, `ash-window` and `raw-window-handle` from the dependency table.
Jasper-Bekkers
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
imgui=>eguiconversion in #176 all window-based examples were removed but none of their dependencies were removed, causing a suspiciously-successfulraw-window-handle 0.6bump bydependabot(#179) despite this being fully incompatible with the currentwinit 0.28release, as well asash-window 0.12.Delete
winit,ash-windowandraw-window-handlefrom the dependency table.