❓️ rename_allocation via interior mutability
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey tom I think these changes are useful, if you have time could you rebase them on main & drop the formatting changes in Cargo.toml? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ohai, I'm not sure if this is useful to you, or a desirable change, but I thought I'd share anyway.
In our engine, we currently keep
Allocations immutable, so updating their debug names isn't possible without wrapping them in some sorta mutex.Here, I use
arc-swapto allow interior mutability for the debug names.(sorry for the noise in Cargo.toml, it got auto-formatted. I can clean it up if you're interested in the change)