Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Change #202

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Font Change #202

merged 5 commits into from
Feb 25, 2024

Conversation

HappyLife2
Copy link
Contributor

Description

The changes made to the code involve adding a font family declaration and adjusting the font size. Here's a brief description:

1. Font Family Declaration:

In the <style> tag, a rule is added to specify the font family for the entire body of the HTML document using the body selector. The font family is set to 'Times New Roman', Times, serif;, which means the browser will first attempt to use Times New Roman, then fall back to the Times font, and finally to a generic serif font if neither of the specified fonts is available.

2. Font Size Adjustment:

A rule is added to adjust the font size for the body text using the font-size property. The font size is set to 18px, but it can be adjusted as needed.

Checklist

  • Ran the Black Formatter and djLint-er on any new code (checks will fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • ✨ Feature

Added/updated tests?

  • 👍 yes

Related PRs, Issues, etc

Copy link
Owner

@TreyWW TreyWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Sorry I forgot to mention, could you run the formatter and push that too please.

docs

poetry install --with dev
djlint ./frontend/templates --reformat

@TreyWW
Copy link
Owner

TreyWW commented Feb 20, 2024

To fit with both colour themes, I've found that this works slightly better:

(BANNER)
- class="print-ignore fixed top-0 left-0 z-50 grid grid-cols-3 w-full p-4 bg-base-100 glass-effect"
+ class="print-ignore fixed top-0 left-0 z-50 grid grid-cols-3 w-full p-4 bg-base-100 shadow text-base-content"
(MAIN)
- <div class="max-w-3xl mx-auto p-6 bg-white rounded-lg shadow my-6 mt-16 min-h-screen glass-effect">
+ <div class="max-w-3xl mx-auto p-6 bg-white rounded-lg shadow my-6 mt-16 min-h-screen">

@TreyWW TreyWW merged commit 4631b8b into TreyWW:main Feb 25, 2024
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants