Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pre-commit hook #257

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Added pre-commit hook #257

merged 7 commits into from
Apr 4, 2024

Conversation

introkun
Copy link
Contributor

@introkun introkun commented Mar 31, 2024 •
edited
Loading

Description

Checklist

  • Ran the Black Formatter and
    djLint-er on any new code
    (checks
    will
    fail without)
  • Made any changes or additions to the documentation where required
  • Changes generate no new warnings/errors
  • New and existing unit tests pass locally with my
    changes

What type of PR is this?

  • ♻️ Local pre-commit hook for developers

Added/updated tests?

  • 🙅 no, because they aren't needed

@TreyWW TreyWW marked this pull request as draft April 1, 2024 15:58
@introkun introkun marked this pull request as ready for review April 2, 2024 00:29
@introkun
Copy link
Contributor Author

introkun commented Apr 2, 2024

Done @TreyWW

@introkun
Copy link
Contributor Author

introkun commented Apr 2, 2024

typos error is fixed in #272

@introkun introkun mentioned this pull request Apr 2, 2024
Merged
4 tasks
@TreyWW TreyWW mentioned this pull request Apr 2, 2024
Closed
@TreyWW
Copy link
Owner

TreyWW commented Apr 2, 2024

Typo checks now merged, feel free to update this with main to get updated status checks

@TreyWW TreyWW marked this pull request as draft April 2, 2024 20:12
@introkun introkun marked this pull request as ready for review April 3, 2024 02:08
@introkun
Copy link
Contributor Author

introkun commented Apr 3, 2024

ready @TreyWW

TreyWW
TreyWW requested changes Apr 3, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@introkun
Copy link
Contributor Author

introkun commented Apr 3, 2024

fixed review notes @TreyWW

@introkun
Copy link
Contributor Author

introkun commented Apr 3, 2024

ready for review

@TreyWW
Copy link
Owner

TreyWW commented Apr 4, 2024

image

Could poetry be reverted and README be fixed (sorry I merged your other PR a few mins ago)

@TreyWW TreyWW merged commit 1c7713a into TreyWW:main Apr 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TreyWW TreyWW TreyWW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@introkun @TreyWW