Code improvements in utils.py #288
Conversation
Here's the list of modifications made: 1. Added `set_cache` and `get_cache` functions to simplify cache manipulation. 2. Added `render_quota_error` and `render_quota_error_response` functions to make the code more modular and reusable. 3. Added the `redirect_to_last_visited` function to handle redirection to the last visited URL more clearly. 4. Reorganized imports to improve code readability.
|
Hey @Collins-Webdev, For the redirect_to_last_visited function, instead of accepting a last visited URL could we maybe figure that out in the function for less repeated code? The previous url is stored in request.session (check middleware file for exact usage). You could maybe accept an optional argument for a URL to redirect to if the user doesn't have a previous URL and if it's not found redirect to the argument or dashboard. I hope that's okay, thanks again for the PR. |
…ion. Instead of accepting a last visited URL as an argument, the function now automatically determines the previous URL from the user's session, in line with Django's session management. Additionally, I've added an optional argument fallback_url to handle cases where no previous URL is found in the session.
Here's the modified function:
def redirect_to_last_visited(request, fallback_url="dashboard"):
"""
Redirects user to the last visited URL stored in session.
If no previous URL is found, redirects to the fallback URL.
:param request: HttpRequest object
:param fallback_url: URL to redirect to if no previous URL found
:return: HttpResponseRedirect object
"""
try:
last_visited_url = request.session.get("last_visited", fallback_url)
return HttpResponseRedirect(last_visited_url)
except KeyError:
return HttpResponseRedirect(fallback_url)
Hello @TreyWW , thank you for the feedback, I appreciate the opportunity to contribute. I've made the requested modifications to the redirect_to_last_visited function. Instead of accepting the last visited URL as an argument, the function now checks the request.session for the previous URL. If it's found, the user is redirected there; otherwise, they are redirected to the dashboard or the optional URL argument if provided. Please review the changes and let me know if there's anything else I can assist with. |
Here's the list of modifications made:
set_cacheandget_cachefunctions to simplify cache manipulation.render_quota_errorandrender_quota_error_responsefunctions to make the code more modular and reusable.redirect_to_last_visitedfunction to handle redirection to the last visited URL more clearly.