Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty headers #107

Open
blacktemplar opened this issue Apr 4, 2020 · 0 comments · May be fixed by #108
Open

Allow empty headers #107

blacktemplar opened this issue Apr 4, 2020 · 0 comments · May be fixed by #108

Comments

@blacktemplar
Copy link
Contributor

At the moment the library expects a header to be non-empty (otherwise it will error with "missing header"). The spec draft specifies in 2.3.4.2 (https://tools.ietf.org/html/draft-cavage-http-signatures-12#section-2.3) how to handle empty headers.

This library should also accept and correctly sign requests with empty headers.

@blacktemplar blacktemplar linked a pull request Apr 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant