Skip to content

Commit

Permalink
doc,meta: update PR approving info
Browse files Browse the repository at this point in the history
Refs: nodejs#22255

PR-URL: nodejs#24561
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
  • Loading branch information
vsemozhetbyt authored and Trott committed Nov 22, 2018
1 parent d1a55d3 commit 9c7b87b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,8 @@ unhelpful is likely safe to ignore.
### Step 10: Landing

In order to land, a Pull Request needs to be reviewed and [approved][] by
at least one Node.js Collaborator and pass a
at least two Node.js Collaborators (one Collaborator approval is enough if the
pull request has been open for more than 7 days) and pass a
[CI (Continuous Integration) test run][]. After that, as long as there are no
objections from other contributors, the Pull Request can be merged. If you find
your Pull Request waiting longer than you expect, see the
Expand Down

0 comments on commit 9c7b87b

Please sign in to comment.