Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Update ember-cli-mirage to 0.2.4 #37

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Update ember-cli-mirage to 0.2.4 #37

merged 2 commits into from
Jan 13, 2017

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented Jun 3, 2016 •
edited
Loading

supersedes #32

Updates ember-cli-mirage to version 0.2.0

  • ensure lodash is updated (remove from bower?)
  • update api
  • make tests pass

@acburdine acburdine force-pushed the ember-cli-mirage-2.0 branch 2 times, most recently from 0850f1d to f70734f Compare June 4, 2016 18:03
@acburdine acburdine mentioned this pull request Jun 4, 2016
Closed
@acburdine
Copy link
Member Author

@kevinansfield With Mirage 0.2 comes a lot of improvements on model relationships, especially where sideloading/embedding is concerned. Should this also target that area of the mirage config and mimic the actual API behavior?

I'm thinking primarily of doing things like taking GET /posts/?include=tags,author and making that actually affect the mirage behavior.

@kevinansfield
Copy link
Member

Yeah, my plan was to completely switch over to the new mirage ORM and mimic as much of the API behaviour as possible. I tried it on a side project and had issues with many to many relationships but I don't think we'll have the same issues in ghost as our setup is a bit different.

@kevinansfield kevinansfield mentioned this pull request Jun 23, 2016
Closed
@acburdine acburdine force-pushed the ember-cli-mirage-2.0 branch 2 times, most recently from 676c9cf to 46dff45 Compare July 31, 2016 20:41
@kevinansfield kevinansfield mentioned this pull request Sep 20, 2016
Closed
@kevinansfield kevinansfield mentioned this pull request Oct 21, 2016
Closed
@kevinansfield kevinansfield mentioned this pull request Nov 7, 2016
Closed
@acburdine
Copy link
Member Author

@kevinansfield Still running into some various minor acceptance test issues, but could still use a review at some point (no rush though 😉)

@acburdine acburdine mentioned this pull request Jan 4, 2017
Merged
@acburdine acburdine changed the title [WIP] Update ember-cli-mirage to 0.2.0 Update ember-cli-mirage to 0.2.0 Jan 8, 2017
@acburdine acburdine changed the title Update ember-cli-mirage to 0.2.0 Update ember-cli-mirage to 0.2.4 Jan 8, 2017
@acburdine
Copy link
Member Author

@kevinansfield it's green now 🎉

acburdine
acburdine commented Jan 9, 2017
View reviewed changes
mirage/utils.js
}

// minimalist deparam implementation
export function deparam(string) {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@acburdine
deps: [email protected]
5d48eef 
- remove lodash from bower
- move all resources to /mirage instead of /app/mirage
- update endpoints to use ORM
- general cleanup
@acburdine
Update acceptance tests to use new mirage api
67a8e63
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 80.375% when pulling 67a8e63 on acburdine:ember-cli-mirage-2.0 into 21180c4 on TryGhost:master.

@kevinansfield kevinansfield merged commit f110a97 into TryGhost:master Jan 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinansfield kevinansfield kevinansfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acburdine @kevinansfield @coveralls