Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added e2e tests for tag.added webhook #15540

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

dshubhadeep
Copy link
Contributor

Added e2e tests for tag.added webhook

Ref - #15537

@daniellockyer daniellockyer requested a review from naz October 6, 2022 07:32
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 52.48% // Head: 52.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (40b8965) compared to base (12aaaa6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15540   +/-   ##
=======================================
  Coverage   52.48%   52.48%           
=======================================
  Files        1433     1433           
  Lines       92854    92854           
  Branches    10353    10353           
=======================================
+ Hits        48732    48736    +4     
+ Misses      42907    42905    -2     
+ Partials     1215     1213    -2     
Impacted Files Coverage Δ
ghost/admin/app/components/gh-image-uploader.js 87.07% <0.00%> (+2.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@naz naz mentioned this pull request Oct 7, 2022
29 tasks
@@ -0,0 +1,64 @@
const {agentProvider, mockManager, fixtureManager, matchers} = require('../utils/e2e-framework');
const {anyGhostAgent, anyObjectId, anyISODateTime, anyUuid, anyString, anyContentVersion, anyNumber, anyLocalURL} = matchers;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anyUuid matcher is not used anywhere in the test. Would be great to clean these up as you go 🙌

Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks @dshubhadeep 👍

@naz naz merged commit 4110ffa into TryGhost:main Oct 7, 2022
@dshubhadeep dshubhadeep deleted the test-tag-added-webhook branch October 7, 2022 05:02
@ErisDS
Copy link
Member

ErisDS commented Oct 10, 2022

Hi @dshubhadeep Not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts. We have plenty of open issues and ongoing projects for hacktoberfest and would love to see you around again 👋

@dshubhadeep
Copy link
Contributor Author

Thank you @ErisDS. Much appreciated.
It's generally easier to find issues during hacktoberfest 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants