Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed show_subhead to show_subtitle #20320

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Jun 4, 2024

closes https://linear.app/tryghost/issue/MOM-194

  • whilst working on the feature our naming changed from "Subhead" to "Subtitle"
  • this rename of the newsletter design setting column brings naming back into a consistent state before public release

@github-actions github-actions bot added affects:admin Anything relating to Ghost Admin migration [pull request] Includes migration for review labels Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@kevinansfield kevinansfield force-pushed the rename-show-subhead branch 4 times, most recently from de38e2f to 904e3eb Compare June 4, 2024 10:27
closes https://linear.app/tryghost/issue/MOM-194

- whilst working on the feature our naming changed from "Subhead" to "Subtitle"
- this rename of the newsletter design setting column brings naming back into a consistent state
Copy link
Contributor

@sagzy sagzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinansfield kevinansfield enabled auto-merge (squash) June 4, 2024 10:56
@kevinansfield kevinansfield merged commit 952a89f into TryGhost:main Jun 4, 2024
22 checks passed
@mheland
Copy link

mheland commented Oct 10, 2024

Client had Ghost 5.83.0 install on DO Droplet, upgrade fails, possibly related?
Which intermediate version is needed to get the show_subtitle field inserted into DB?

Unable to upgrade Ghost from v5.83.0 to v5.96.0. Would you like to revert back to v5.83.0?
Message: Ghost was able to start, but errored during boot with: ALTER TABLE `newsletters` RENAME COLUMN `show_subtitle` TO `show_subhead`; - Unknown column 'show_subtitle' in 'newsletters'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin migration [pull request] Includes migration for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants