fix cmake error when building without tests (open-telemetry#271)

TuckTuckFloof · Aug 12, 2020 · 119e030 · 119e030
1 parent 7e0287c
commit 119e030
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 18 deletions.
diff --git a/exporters/ostream/CMakeLists.txt b/exporters/ostream/CMakeLists.txt
@@ -3,18 +3,20 @@ include_directories(include)
 add_library(opentelemetry_exporter_ostream_metrics src/metrics_exporter.cc)
 add_library(opentelemetry_exporter_ostream_span src/span_exporter.cc)
 
-add_executable(ostream_metrics_test test/ostream_metrics_test.cc)
-add_executable(ostream_span_test test/ostream_span_test.cc)
+if(BUILD_TESTING)
+ add_executable(ostream_metrics_test test/ostream_metrics_test.cc)
+ add_executable(ostream_span_test test/ostream_span_test.cc)
 
-target_link_libraries(
- ostream_span_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
- opentelemetry_exporter_ostream_span)
+ target_link_libraries(
+  ostream_span_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
+  opentelemetry_exporter_ostream_span)
 
-target_link_libraries(
- ostream_metrics_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
- opentelemetry_exporter_ostream_metrics)
+ target_link_libraries(
+  ostream_metrics_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
+  opentelemetry_exporter_ostream_metrics)
 
-gtest_add_tests(TARGET ostream_metrics_test TEST_PREFIX exporter. TEST_LIST
- ostream_metrics_test)
-gtest_add_tests(TARGET ostream_span_test TEST_PREFIX exporter. TEST_LIST
- ostream_span_test)
+ gtest_add_tests(TARGET ostream_metrics_test TEST_PREFIX exporter. TEST_LIST
+ ostream_metrics_test)
+ gtest_add_tests(TARGET ostream_span_test TEST_PREFIX exporter. TEST_LIST
+ ostream_span_test)
+endif() # BUILD_TESTING
diff --git a/exporters/otlp/CMakeLists.txt b/exporters/otlp/CMakeLists.txt
@@ -4,9 +4,11 @@ add_library(opentelemetry_exporter_otprotocol src/recordable.cc)
 target_link_libraries(opentelemetry_exporter_otprotocol
  $<TARGET_OBJECTS:opentelemetry_proto>)
 
-add_executable(recordable_test test/recordable_test.cc)
-target_link_libraries(
- recordable_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
- opentelemetry_exporter_otprotocol protobuf::libprotobuf)
-gtest_add_tests(TARGET recordable_test TEST_PREFIX exporter. TEST_LIST
- recordable_test)
+if(BUILD_TESTING)
+ add_executable(recordable_test test/recordable_test.cc)
+ target_link_libraries(
+ recordable_test ${GTEST_BOTH_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT}
+ opentelemetry_exporter_otprotocol protobuf::libprotobuf)
+ gtest_add_tests(TARGET recordable_test TEST_PREFIX exporter. TEST_LIST
+ recordable_test)
+endif() # BUILD_TESTING