Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If numberOfSegments is integer, no need to plus 1 in line-chunk #1044

Closed
xiongjiabin opened this issue Oct 26, 2017 · 2 comments
Closed

If numberOfSegments is integer, no need to plus 1 in line-chunk #1044

xiongjiabin opened this issue Oct 26, 2017 · 2 comments
Labels
bug
Milestone
5.0.0

Comments

@xiongjiabin
Copy link
Contributor

if the line length is 100, and segment length is 10, the number of segments is just 10, no need to plus 1, otherwise will throw an exception later. The right code works.

image
@DenisCarriere
Copy link
Member

👍 Feel free to send a PR.

@DenisCarriere DenisCarriere added this to the 5.1.0 milestone Oct 26, 2017
@DenisCarriere DenisCarriere modified the milestones: 5.1.0, 5.2.0 Nov 27, 2017
@rowanwins
Copy link
Member

Done in #1046

@DenisCarriere DenisCarriere modified the milestones: 5.2.0, 5.0.0 Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@DenisCarriere @xiongjiabin @rowanwins