concave: replace deprecated topojson dependency #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Turfjs#2005 (allowing import with node 15/npm 7)
rowanwins
reviewed
Feb 18, 2021
| @@ -74,6 +74,7 @@ | |||
| "@turf/invariant": "^6.3.0", | |||
| "@turf/meta": "^6.3.0", | |||
| "@turf/tin": "^6.3.0", | |||
| "topojson": "3.x" | |||
| "topojson-client": "3.x", | |||
There was a problem hiding this comment.
Do you have a preference here @mfedderly for package version numbers?
There was a problem hiding this comment.
Its my habit to just always use ^ or ~ for the simple ranges, but if people want to use .x that's fine too.
|
Has this change been pushed to NPM? I just upgraded my computer and without thinking, I installed the latest version of node, but I still can't install this package... |
justinanderson
added a commit
to CxSci/atlas-of-opportunity
that referenced
this pull request
Apr 15, 2021
Include topojson-* dependencies of turf since turf 6.3.0 fails to install otherwise. See Turfjs/turf#2052 and Turfjs/turf#2037.
justinanderson
added a commit
to CxSci/atlas-of-opportunity
that referenced
this pull request
Apr 16, 2021
Include topojson-* dependencies of turf since turf 6.3.0 fails to install otherwise. See Turfjs/turf#2052 and Turfjs/turf#2037.
justinanderson
added a commit
to CxSci/atlas-of-opportunity
that referenced
this pull request
Apr 21, 2021
Include topojson-* dependencies of turf since turf 6.3.0 fails to install otherwise. See Turfjs/turf#2052 and Turfjs/turf#2037.
|
Any estimate when this will be tagged and released? |
|
Can we help review any other PRs or are there any other blocking issues to prevent a release/npm publish with this fix? |
This was referenced Jun 17, 2021
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2005 (allowing import with node 15/npm 7)
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.