Fix crash on turf.intersect for touching polygons #2238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm test
at the sub modules where changes have occurred.npm run lint
to ensure code style at the turf module level.Submitting a new TurfJS Module: N/A
Hi,
While testing turfjs in MapComplete, I discovered that
turf.intersect(p0, p1)
would crash if these polygons shared a border over multiple points.I've added a testcase for this in the
turf-intersect
-package - which indeed crashed. Then I fixed it by checking that the result of the polygon-clipping would return a correct linear ring (at least for the outer ring).At last, I've updated the documentation to clarify that polygons that touch will return null as well.