New module @turf/boolean-equal

[stebogit]

Imported from turf-equal.
Implements DE-9IM "equal" spatial relation.

TODOs:

• remove redundant coordinated from input features

Thanks @tmcw and @tcql for the original work! 👍

[rowanwins]

Hey @stebogit

Unfortunately this module isn't quite this simple.

For example the following lines should pass

[[0, 0], [2, 2]]
and 
[[0, 0] [,1, 1], [2, 2]]

Shapely provides this helpful definition

Returns True if the set-theoretic boundary, interior, and exterior of the object coincide with those of the other.

So points are easy, lines and polygons need a bit more thought.

Me thinks you'll probably need to start from scratch.

[DenisCarriere]

@rowanwins 👍 Good catch, added that test in this module.

Shapely successfully passes (True) & this current library tests fail (False) on lines-extra-vertices.geojson.

[stebogit]

the following lines should pass

[[0, 0], [2, 2]]
and 
[[0, 0] [,1, 1], [2, 2]]

@rowanwins @DenisCarriere the test now would pass if I could install the brand new @turf/clean-coords module; I tested it referencing the local module but I could not figure out how to install it from package.json. I tried yarn, npm and lerna bootstrap, but nothing. Can you please fix that?

BTW I had to fix how @turf/clean-coords handled a single clean segment (like [[0, 0], [2, 2]]) cause it was failing. Hope it's fine.

Please fill free to add more tests with unclean features if you like.

[DenisCarriere]

Why are we throwing an error, shouldn't this simply return false?

if (type1 !== type2) return false;

[stebogit]

ahahah! yes that's right @DenisCarriere! 😅

[DenisCarriere]

👍 Published

[rowanwins]

From my quick glance at the source and tests this doesn't support polys that have different starting vertices
eg

[[[0,0],[1,1],[1,0],[0,0]]]
// should equal true
[[[1,1],[1,0],[0,0],[1,1]]]

So we might need a bit more thought here.