Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/page links landing page #532

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

A-Ashiq
Copy link
Contributor

@A-Ashiq A-Ashiq commented Oct 18, 2024

Description

  • Implements a new function getPath() to be used to get the relative path associated with a given URL
  • Calls this function throughout the landing page/menu so that all page links are provided to next.js as relative paths

Fixes #CDD-2224

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Unit tests coverage

Lines Statements Branches Functions
Coverage: 93%
92.38% (1759/1904) 82.35% (406/493) 89.93% (259/288)
Tests Skipped Failures Errors Time
470 0 💤 0 ❌ 0 🔥 16.065s ⏱️

@phill-stanley phill-stanley merged commit 0b0e45b into main Oct 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants