Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Revision for CrossEncoder #2469

Closed
michaelfeil opened this issue Feb 5, 2024 · 2 comments · Fixed by #2479
Closed

Feat: Add Revision for CrossEncoder #2469

michaelfeil opened this issue Feb 5, 2024 · 2 comments · Fixed by #2479
Assignees
@fkdosilovic
Labels
good first issue Good for newcomers

Comments

@michaelfeil
Copy link
Contributor

I noticed that in #2419 there was a revision implemented!
For CrossEncoder, there is no revision. The goal would be to implement revision in similar fashion.

Potentially could be a starter issue
@tomaarsen
Copy link
Collaborator

Indeed, revision must currently be specified via automodel_args & tokenizer_args, but I'm not a big fan of that. It seems preferable to align the signatures of the CrossEncoder and the SentenceTransformer as much as possible. I'd like to see the revision implemented in the CrossEncoder too.

  • Tom Aarsen

@tomaarsen tomaarsen added the good first issue Good for newcomers label Feb 5, 2024
@fkdosilovic
Copy link
Contributor

/take

@fkdosilovic fkdosilovic mentioned this issue Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkdosilovic fkdosilovic

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add revision parameter to CrossEncoder. fkdosilovic/sentence-transformers
3 participants
@fkdosilovic @tomaarsen @michaelfeil