Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable smart punctuation #1192

Merged

Conversation

VojtechStep
Copy link
Collaborator

@VojtechStep VojtechStep commented Oct 8, 2024

Turns -- and --- to ndash and mdash, respectively, and automatically inserts paired quotation marks; see https://rust-lang.github.io/mdBook/format/markdown.html#smart-punctuation.

Note that the option is called curly-quotes in the version of mdbook we use. In later versions it's called smart-punctuation.

@VojtechStep VojtechStep added enhancement New feature or request website labels Oct 8, 2024
@fredrik-bakke
Copy link
Collaborator

Note that the option is called curly-quotes in the version of mdbook we use. In later versions it's called smart-punctuation.

Could you add this as a comment in the .toml?

@VojtechStep
Copy link
Collaborator Author

I can do that tomorrow, though I don't think it's necessary, since curly-quotes will remain a deprecated alias in future version of mdbook, with a printed warning, so it's not going to silently break when we update

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented Oct 9, 2024

I have another concern about this since the configuration name changed in mdbook 4.38 and I'm using a later* version locally. Does that mean I have to downgrade my version of mdbook? Would it be reasonable/possible to just update our mdbook version so that we don't have to worry about this in the future?

@fredrik-bakke
Copy link
Collaborator

Never mind, I see in their changelog that they are keeping the old name around for now.

book.toml Outdated Show resolved Hide resolved
@fredrik-bakke
Copy link
Collaborator

I've enabled auto-merge 👍

@fredrik-bakke fredrik-bakke merged commit b384b14 into UniMath:master Oct 9, 2024
4 checks passed
@VojtechStep
Copy link
Collaborator Author

Would it be reasonable/possible to just update our mdbook version

Of course eventually we want to upgrade, but we need to update our changes to the files in theme/ to match the new version, since mdbook sometimes breaks those. IIRC last time we tried to "just update our mdbook version" the navigation buttons and left ToC stopped working, and nobody's yet invested the necessary time to fix it, so we're keeping the version of mdbook and its plugins pinned to an older version

@VojtechStep VojtechStep deleted the feature/smart-punctuation branch October 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants