[python] Introducing virtual objects with multiple sets of slots #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...hon-main/src/main/kotlin/org/usvm/machine/interpreters/concrete/ConcretePythonInterpreter.kt
Fixed
Show fixed
Hide fixed
tochilinak
reviewed
Aug 19, 2024
usvm-python/usvm-python-main/src/main/java/org/usvm/interpreter/CPythonAdapter.java
Outdated
Show resolved
Hide resolved
|
Also, please add some unit tests for generated virtual objects. For example, add a test where you create an object without You might need this function |
tochilinak
reviewed
Aug 22, 2024
tochilinak
reviewed
Aug 22, 2024
tochilinak
reviewed
Aug 22, 2024
tochilinak
changed the title
tochilinak
requested changes
Aug 23, 2024
usvm-python/usvm-python-main/src/main/kotlin/org/usvm/machine/types/VirtualTypes.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Show resolved
Hide resolved
usvm-python/src/test/kotlin/org/usvm/samples/VirtualObjectsTest.kt
Outdated
Show resolved
Hide resolved
usvm-python/src/test/kotlin/org/usvm/samples/VirtualObjectsTest.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-main/src/main/kotlin/org/usvm/machine/types/VirtualTypes.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Outdated
Show resolved
Hide resolved
...hon-main/src/main/kotlin/org/usvm/machine/interpreters/concrete/ConcretePythonInterpreter.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
...n-annotations/src/main/kotlin/org/usvm/annotations/codegeneration/AvailableSlotGeneration.kt
Fixed
Show fixed
Hide fixed
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Fixed
Show fixed
Hide fixed
...hon-main/src/main/kotlin/org/usvm/machine/interpreters/concrete/utils/VirtualPythonObject.kt
Fixed
Show fixed
Hide fixed
|
Fine with me. Waiting for review from @sergeypospelov. |
sergeypospelov
requested changes
Aug 26, 2024
...hon-main/src/main/kotlin/org/usvm/machine/interpreters/concrete/utils/VirtualPythonObject.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-main/src/main/kotlin/org/usvm/machine/types/VirtualTypes.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Outdated
Show resolved
Hide resolved
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Outdated
Show resolved
Hide resolved
|
General comment for @sergeypospelov. This is some preliminary work for fixing a major issue: |
tochilinak
approved these changes
Aug 29, 2024
...n-annotations/src/main/kotlin/org/usvm/annotations/codegeneration/AvailableSlotGeneration.kt
Fixed
Show fixed
Hide fixed
...n-annotations/src/main/kotlin/org/usvm/annotations/codegeneration/AvailableSlotGeneration.kt
Fixed
Show fixed
Hide fixed
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Fixed
Show fixed
Hide fixed
usvm-python/usvm-python-annotations/src/main/kotlin/org/usvm/annotations/ids/SlotId.kt
Fixed
Show fixed
Hide fixed
sergeypospelov
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to fix the problem with
PyMockTypeStreamwhen it doesn't start withMockType.Now it is possible to create multiple virtual object types, the slots for which are specified using a mask.