Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added possibility to create the Repository in the Builder #214

Merged

Conversation

michael-schmetter
Copy link
Contributor

@michael-schmetter michael-schmetter commented Jul 5, 2024

Description

Refactored the UnleashBuilder.php to enable it to also build only the repository

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@michael-schmetter michael-schmetter force-pushed the feat/expose-repository-in-builder branch 2 times, most recently from 247a632 to 589d052 Compare July 5, 2024 10:25
@michael-schmetter
Copy link
Contributor Author

@RikudouSage What do you think?

@RikudouSage
Copy link
Collaborator

@michael-schmetter Sorry, I totally missed this! I'll do a code review today and let you know.

Copy link
Collaborator

@RikudouSage RikudouSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I only found one small issue.

src/UnleashBuilder.php Outdated Show resolved Hide resolved
- refactored the UnleashBuilder.php to enable it to also build only the repository
@michael-schmetter michael-schmetter force-pushed the feat/expose-repository-in-builder branch from 589d052 to 402929a Compare July 15, 2024 05:24
@RikudouSage RikudouSage merged commit 35829b1 into Unleash:main Jul 18, 2024
12 checks passed
@michael-schmetter michael-schmetter deleted the feat/expose-repository-in-builder branch July 18, 2024 10:04
@michael-schmetter
Copy link
Contributor Author

@RikudouSage Short question: What do you think when this will be released?

@RikudouSage
Copy link
Collaborator

@michael-schmetter Just released it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants