Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Add an example for http timeout #221

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Chore: Add an example for http timeout #221

merged 2 commits into from
Jul 25, 2024

Conversation

RikudouSage
Copy link
Collaborator

Description

Adds an example on how to add a http client timeout for the two most popular http clients.

Fixes #220

Checklist:

  • I have performed a self-review of my own code

@RikudouSage RikudouSage mentioned this pull request Jul 25, 2024
Closed
1 task
sighphyre
sighphyre approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure looks good!

Small suggestion but since this is already importing common, might as add ->withHeader('Authorization', $apiKey) and do an isEnabled("myFeature"); call

@RikudouSage
Copy link
Collaborator Author

Added it, thanks.

@RikudouSage RikudouSage merged commit e10aed9 into main Jul 25, 2024
12 checks passed
@RikudouSage RikudouSage deleted the chore/timeout-example branch July 25, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: method ->withTimeout(secs)
2 participants
@RikudouSage @sighphyre