feat: add extended metrics metadata #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikudouSage
reviewed
Jul 26, 2024
RikudouSage
approved these changes
Jul 26, 2024
Co-authored-by: Rikudou_Sage <[email protected]>
Co-authored-by: Rikudou_Sage <[email protected]>
|
Just a side note, if you ever wonder what php versions people use, at Packagist (the official package repository) they make the stats available publicly: https://packagist.org/packages/unleash/client/php-stats |
Oh that's very nice, I did not know about that, very useful, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds extended metrics/registration metadata. This doesn't make any changes in terms of public API or behavior, but allows the Unleash server better insight into SDKs running in the wild.
Yggdrasil version is currently defaulted to null. Yggdrasil is long term plans, which may never make it into this project
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
We don't really test against any of the metrics/registration data in this SDK (probably sane). So I've opted just to plug this into Unleash and observe the incoming data
Checklist: