Feature/aggregate strategies api #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this PR is merged i will perform some testing with actual prod-data to see that it behaves as ut should. |
ivarconr
force-pushed
the
feature/aggregate_strategies_api
branch
from
4944a04
to
e373f1c
Compare
| @@ -74,6 +70,7 @@ module.exports = function (db, eventStore) { | |||
| } | |||
|
|
|||
| function updateFeature (data) { | |||
| console.log(data); | |||
This commit changes the features-tables:
- drop columns 'strategy' and 'parameters'
- add column 'strategies' of type json.
- migrates existing strategy-mappings in to the new format.
The idea is that the 'strategies' column should contain a json-array
of strategy-configuration for the toggle:
```
[{
"name" : "strategy1",
"parameters": { "name": "vale" }
}]
```
To make sure to not break exiting clients the api is extended with a
mapping layer (adding old fields to the json-respons, and mapping
to the new format on create/update a feature toggle.
this commit is first step in solving #102
…t the same time Relates #102
…client parsers relates to #102
ivarconr
force-pushed
the
feature/aggregate_strategies_api
branch
from
7225c6f
to
21e8234
Compare
|
wfm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for (see #102).
In this first implementation unleash-api will return both the new
strategiesproperty along with the old deprecatedstrategyandparametersproperty. These deprecated props will be removed in the next version of .The unleash-api will translate "legacy" format into to the new format when it recieves POST requests to create or PUT to update feature toggles.