Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resample_swc bugs #35

Open
patrick-nicodemus opened this issue Nov 15, 2022 · 0 comments
Open

resample_swc bugs #35

patrick-nicodemus opened this issue Nov 15, 2022 · 0 comments

Comments

@patrick-nicodemus
Copy link

In released_plugins/v3d_plugins/resample_swc/resample_swc_func.cpp there are two problems.
In the code

	QTextStream myfile(&file);
	myfile<<"# generated by Vaa3D Plugin resample_swc"<<endl;
	myfile<<"# source file(s): "<<fileOpenName<<endl;
	myfile<<"# id,type,x,y,z,r,pid"<<endl;
	for (V3DLONG i=0;i<lN.size();i++)

The endlines in this code are not being processed right for me.
I believe it is assuming that this is the stdlib endl rather than the QText endl. I think you should just be able to change it to Qt::endl and it should be fine.

A slightly more serious issue,
http://www.neuronland.org/NLMorphologyConverter/MorphologyFormats/SWC/Spec.html
The specification here says that "Parent samples should appear before any child samples." This is not satisfied in the current incarnation. The graph should be sorted topologically before it is written to the file.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant