Fix incorrect host header memmove()s. Fixes #47

ValdikSS · Dec 12, 2017 · 5f23199 · 5f23199
1 parent 81718f1
commit 5f23199
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/goodbyedpi.c b/goodbyedpi.c
@@ -513,7 +513,8 @@ int main(int argc, char *argv[]) {
  /* Move one byte to the LEFT from "Host:"
  * to the end of User-Agent
  */
- memmove(host_addr - 1, host_addr, useragent_len);
+ memmove(host_addr - 1, host_addr,
+ (PVOID)useragent_addr + useragent_len - (PVOID)host_addr);
  host_addr -= 1;
  /* Put space in the end of User-Agent header */
  *(char*)((PVOID)useragent_addr + useragent_len - 1) = ' ';
@@ -528,7 +529,7 @@ int main(int argc, char *argv[]) {
  */
  memmove((PVOID)useragent_addr + useragent_len + 1,
  (PVOID)useragent_addr + useragent_len,
- useragent_len - 1);
+ (PVOID)host_addr - 1 - ((PVOID)useragent_addr + useragent_len));
  /* Put space in the end of User-Agent header */
  *(char*)((PVOID)useragent_addr + useragent_len) = ' ';
  should_recalc_checksum = 1;