Optimize CGRAM slots for custom characters #93
Replies: 2 comments 1 reply
-
Hi, @jlnbotello. Nice catch, I'll give it a test soon. You're welcome to open a pull request if you want. Thanks for the tip. |
Beta Was this translation helpful? Give feedback.
-
Hello, I would like to point out though that some "disclaimers" should be added to the library. I found that my LCD is a Hitachi HD44780 and uses ROM A00. People with ROM A02 would have a completely different set (for example I loaded 0b01111110 as right arrow, but in A02 this would be a tilde (~) instead). So, as default A00, but an option to change set should be included. Here is the reference for the part: I will try to write a new 'ROMglyphs.h' with names and values and add their behaviour to the LiquidLine class. Unfortunately I have never used git with other contributors, I can try to make a pull request, this would be my first contribution to a project. Before I add anything, can I ask if I can create a branch just in case @VasilKalchev ? |
Beta Was this translation helpful? Give feedback.
-
Hi Vasil,
First of all, thanks for sharing this amazing library. Congrats! 👏
I've been working with custom characters and I noticed that library use custom characters for left and right focus.
Left and right arrows are already defined on CGROM as 0x7F and 0x7E respectively.
So to release 25% of slots (2/8) of CGRAM, I suggest using CGROM chars.
I hope this could help to improve the library.
Regards,
Julian
Code references:
https:/VaSe7u/LiquidMenu/blob/37dbcb9412725ce78e3b5406cc69e13aaee08779/src/LiquidMenu.cpp#L283
https:/VaSe7u/LiquidMenu/blob/37dbcb9412725ce78e3b5406cc69e13aaee08779/src/LiquidMenu.cpp#L284
https:/VaSe7u/LiquidMenu/blob/1b37ac6b20a84f711d61584ea952bb629a8cf60e/src/LiquidLine.cpp#L113
https:/VaSe7u/LiquidMenu/blob/1b37ac6b20a84f711d61584ea952bb629a8cf60e/src/LiquidLine.cpp#L121
Ref: http://www.electronic-engineering.ch/microchip/datasheets/lcd/lcd_data_sheets.html
Beta Was this translation helpful? Give feedback.
All reactions