Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

[FIX] odoo80: Fix pypa/setuptools#942 #190

Merged
merged 2 commits into from
Feb 9, 2017

Conversation

moylop260
Copy link
Contributor

@moylop260 moylop260 commented Feb 9, 2017

Avoid the following traceback:

Generated script '/home/user/plone/zinstance/bin/buildout'.
Traceback (most recent call last):
  File "bin/buildout", line 13, in <module>
    import zc.buildout.buildout
  File "/home/user/.buildout/eggs/zc.buildout-2.5.3-py2.7.egg/zc/buildout/buildout.py", line 18, in <module>
    import zc.buildout.easy_install
  File "/home/user/.buildout/eggs/zc.buildout-2.5.3-py2.7.egg/zc/buildout/easy_install.py", line 26, in <module>
    import pkg_resources
  File "/home/user/.buildout/eggs/setuptools-34.0.1-py2.7.egg/pkg_resources/__init__.py", line 72, in <module>
    import packaging.requirements
  File "/home/user/.buildout/eggs/packaging-16.8-py2.7.egg/packaging/requirements.py", line 59, in <module>
    MARKER_EXPR = originalTextFor(MARKER_EXPR())("marker")
TypeError: __call__() takes exactly 2 arguments (1 given)

Similar to #189

@moylop260 moylop260 force-pushed the master-vx-fix-setuptools942-moy branch from 5ab33c6 to cedcb71 Compare February 9, 2017 05:21
@moylop260 moylop260 changed the title [FIX] odoo-shippable: Fix pypa/setuptools#942 [FIX] odoo80: Fix pypa/setuptools#942 Feb 9, 2017
@moylop260
Copy link
Contributor Author

@ruiztulio @JesusZapata
I think that this change will fix the current travis issue

Avoid the following traceback:
```bash
Generated script '/home/user/plone/zinstance/bin/buildout'.
Traceback (most recent call last):
  File "bin/buildout", line 13, in <module>
    import zc.buildout.buildout
  File "/home/user/.buildout/eggs/zc.buildout-2.5.3-py2.7.egg/zc/buildout/buildout.py", line 18, in <module>
    import zc.buildout.easy_install
  File "/home/user/.buildout/eggs/zc.buildout-2.5.3-py2.7.egg/zc/buildout/easy_install.py", line 26, in <module>
    import pkg_resources
  File "/home/user/.buildout/eggs/setuptools-34.0.1-py2.7.egg/pkg_resources/__init__.py", line 72, in <module>
    import packaging.requirements
  File "/home/user/.buildout/eggs/packaging-16.8-py2.7.egg/packaging/requirements.py", line 59, in <module>
    MARKER_EXPR = originalTextFor(MARKER_EXPR())("marker")
TypeError: __call__() takes exactly 2 arguments (1 given)
```
@ruiztulio
Copy link
Contributor

@moylop260 I already tested this and didn't work because there is another dependency that is updating the setuptools package later:

a

My guess is that wstools is installing it:

b

and that keep braking the build, but that's a wild guess

@JesusZapata
Copy link
Contributor

@moylop260 @ruiztulio I made the test and it works good

Only add in ${REPO_REQUIREMENTS}/linit_hook/travis/requirements.txt
setuptools==33.1.1

Ran this command
pip install --no-binary pycparser -r ${REPO_REQUIREMENTS}/linit_hook/travis/requirements.txt

image

@moylop260
Copy link
Contributor Author

Are you talking about odoo-shippable right?

That was fixed from #189
Now we have the build success from https://hub.docker.com/r/vauxoo/odoo-80-image-shippable-auto/builds

Now we need a similar patch for https://hub.docker.com/r/vauxoo/odoo-80-image/ to fix the red build too (this pr try fix it the last one)

@moylop260
Copy link
Contributor Author

@ruiztulio
FYI with the last commit now is green (1)
The command "cd ${TRAVIS_BUILD_DIR}/odoo80 && docker build --rm -t vauxoo/odoo-80-image:latest ." exited with 0.

(1) https://travis-ci.org/Vauxoo/docker-odoo-image/builds/199953569#L4201

Could you merge it if you are agree?

@JesusZapata
Copy link
Contributor

@moylop260
The travis fail for
The job exceeded the maximum time limit for jobs, and has been terminated.
https://travis-ci.org/Vauxoo/docker-odoo-image/builds/199953569#L9770

What do you think of this PR #191

@ruiztulio ruiztulio merged commit e307793 into Vauxoo:master Feb 9, 2017
@ruiztulio ruiztulio deleted the master-vx-fix-setuptools942-moy branch February 9, 2017 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants