Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on Ubuntu 20.04 #180

Closed
sambercovici opened this issue Oct 3, 2023 · 6 comments · Fixed by #186 or #188
Closed

Support building on Ubuntu 20.04 #180

sambercovici opened this issue Oct 3, 2023 · 6 comments · Fixed by #186 or #188
Labels
bug Something isn't working wishlist Something that would be nice to have but not a priority
Milestone

Comments

@sambercovici
Copy link

sambercovici commented Oct 3, 2023

Splitting from #176
Currently Vectorscan does not compile on ubuntu 20.04.
To manage that I patched src/util/arch/arm/cpuid_inline.h and added #include <asm/hwcap.h> just before include <sys/auxv.h>

Building with only Neon support then works.

Building with SVE did not work (ISSUE-3 in #176), is it supposed to be supported on ubuntu 20.04 with the clang release it has?

IF SVE is supported, can FAT_RUNTIME be modified so if I turn off SVE2, it will only try to choose between Neon and SVE?
In other words the following:
cmake .. -DBOOST_ROOT=/home/ubuntu/src/vectorscan/build/boost_1_57_0/ -DCMAKE_BUILD_TYPE=Release -DFAT_RUNTIME=on -DBUILD_SVE2_BITPERM=off -DBUILD_SVE2=off -DBUILD_SVE=on

AFIK, in Hyperscan FAT_RUNTIME=on will not include disabled accelerations

@markos
Copy link

markos commented Oct 3, 2023

We may add 20.04 support for Neon only. SVE-only support will not be added for 20.04, mostly because of old compiler support and because most of the optimizations are mainly for SVE2. SVE has only a few basic instructions that can be used as it's mostly for FP operations.

@markos markos added bug Something isn't working wishlist Something that would be nice to have but not a priority labels Oct 3, 2023
@markos markos added this to the 5.4.11 milestone Oct 3, 2023
@sambercovici
Copy link
Author

Will the 20.04 support be done in the same way I did or differently?
When is 5.4.11 expected?

@markos
Copy link

markos commented Oct 3, 2023

It will do something along those lines, yes. As I already said in the other bug report, next release should be done before the end of October.

@sambercovici
Copy link
Author

Amazing work!

@markos
Copy link

markos commented Oct 11, 2023

@sambercovici could you please checkout and test PR #186 on 20.04 and see if it solves your problem? So that I can merge this. I don't have the a 20.04 installation and as I said we don't plan to support it specifically, but I would like you help your usecase.

markos added a commit that referenced this issue Oct 25, 2023
…untu-20.04

Ubuntu 20.04 gcc does not define HWCAP2_SVE2 #180
@markos markos linked a pull request Oct 31, 2023 that will close this issue
@markos
Copy link

markos commented Oct 31, 2023

With #186 and #188 merged this is considered fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wishlist Something that would be nice to have but not a priority
Projects
None yet
2 participants