Rename all custom iterators to adhere to PascalCase
naming convention for classes?
#312
Labels
For:library
The issue is related to library (c++ implementation)
Priority:normal
Work on this sooner rather than later.
Type:discussion
A discussion of some particular topic in wider audience
We currently implement several custom iterator, all named as
const_iterator
, anditerator
. It was suggested that we should rename them toConstIterator
andIterator
to adhere to our naming convention for classes,PascalCase
. Is it possible if we want to keep all the iterator functionality in STL? Does anything expect classes to have exactlyconst_iterator
anditerator
types?This includes
Transitions::const_iterator
,Moves::const_iterator
,OrdVector::const_iterator
,SparseSet::iterator
, and more.As far as I can tell, everything we now use should work as it currently does. However, there might be some issues later on, I am not sure about that. After some research, it seems to me that the name should hopefully not be relevant as far as supported functionality goes.
The text was updated successfully, but these errors were encountered: