Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SynchronizedIterator to SynchronizedAdvancer #314

Open
Adda0 opened this issue Aug 28, 2023 · 4 comments
Open

Rename SynchronizedIterator to SynchronizedAdvancer #314

Adda0 opened this issue Aug 28, 2023 · 4 comments
Labels
For:library The issue is related to library (c++ implementation) Module:nfa The issue is related to Nondeterministic Finite Automata Priority:normal Work on this sooner rather than later. Type:required A required implementation/change necessary in near future

Comments

@Adda0
Copy link
Collaborator

Adda0 commented Aug 28, 2023

Because SynchronizedIterator is not an iterator in a C++-sense, we should rename it to something else. We thought about SynchronizedAdvancer, seeing that it already has the advance() method.
@Adda0 Adda0 added For:library The issue is related to library (c++ implementation) Module:nfa The issue is related to Nondeterministic Finite Automata Type:required A required implementation/change necessary in near future Priority:normal Work on this sooner rather than later. labels Aug 28, 2023
@tfiedor
Copy link
Member

tfiedor commented Aug 30, 2023

Can't this simply be e.g. SynchronizedTraversal? I mean that is at least valid and existing word.

@Adda0
Copy link
Collaborator Author

Adda0 commented Aug 30, 2023 •
edited
Loading

advancer is a valid word, too. See dictionary records for advancer, for example ;) And I must say that I like advancer. It makes it clearer to me what the class does than anything else, to be honest. What do the others think?

@tfiedor
Copy link
Member

tfiedor commented Aug 30, 2023

https://www.oxfordlearnersdictionaries.com/spellcheck/english/?q=advancer
https://dictionary.cambridge.org/dictionary/english/advancer
I rest my case.

@Adda0
Copy link
Collaborator Author

Adda0 commented Aug 30, 2023

Nah, who would believe Oxford or Cambridge dictionaries these days, anyway? I believe in GNU version of the Collaborative International Dictionary of English 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For:library The issue is related to library (c++ implementation) Module:nfa The issue is related to Nondeterministic Finite Automata Priority:normal Work on this sooner rather than later. Type:required A required implementation/change necessary in near future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfiedor @Adda0