forked from argoproject/Argo
-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a "none" option for the top term #1082
Labels
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
type: improvement
Milestone
Comments
aschweigert
added
type: improvement
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
labels
Jan 20, 2016
This is going to involve changes in:
|
benlk
added a commit
that referenced
this issue
Jan 21, 2016
- adds 'none' option to largo_top_tag_display metabox function - changes the validation function for the top term from `intval` to `sanitize_key` because "None" cannot have an id of `'0'` because `'0'` and `0` and `''` are falsy and therefore _largo_meta_box_post_save will remove the option instead of saving it - change largo_top_term so that it outputs `''` if the top term option is `'null'`
This was referenced Jan 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: high
Either blocks work on a priority-normal task or a solution here informs other work.
type: improvement
currently we don't give people the option to not set a top term (even if it's something lame like "uncategorized"). We should add a "none" option to the dropdown menu in the admin and account for this in the front end display of the top tag (by just not returning any of the markup).
needed for RNS-127
The text was updated successfully, but these errors were encountered: