Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve translatability #1592

Open
35 tasks
benlk opened this issue Dec 7, 2018 · 3 comments
Open
35 tasks

Improve translatability #1592

benlk opened this issue Dec 7, 2018 · 3 comments
Labels
hacktoberfest help wanted priority: low Nice-to-have in a release. status: needs docs status: needs review type: bug type: tech debt For necessary updates because code is old
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Dec 7, 2018 •
edited
Loading

The following issues were raised when running grunt pot for 0.6.1:

A long list
  • Warning: The string "Copyright %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/header-footer.php:69)
  • Warning: The string "%s is a member of the Institute for Nonprofit News" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/header-footer.php:85)
  • Warning: The string "Largo has been updated! Please visit the update page to apply a required database update." contains placeholders but has no "translators:" comment to clarify their meaning. (inc/update.php:873)
  • -Warning: The string "Please visit the update page to apply required Largo updates before editing Theme Options." contains placeholders but has no "translators:" comment to clarify their meaning. (inc/update.php:1166)
  • Warning: The string "Default (%s)" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/sidebars.php:182)
  • W arning: The string "" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/pagination.php:128)
  • Warning: The string "" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/pagination.php:135)
  • Warning: The string "" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/pagination.php:145)
  • Warning: The string "" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/pagination.php:152)
  • Warning: The string "%s ago" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/post-tags.php:55)
  • Warning: The string "More from %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/post-tags.php:104)
  • Warning: The string "<%1$s class="post-category-link">%5$s%4$s</%1$s>" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/related-content.php:271)
  • Warning: The string "<%1$s class="post-tag-link">%5$s%4$s</%1$s>" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/related-content.php:292)
  • Warning: The string "Default: %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/post-metaboxes.php:179)
  • Warning: The string "Click here to change the default post template." contains placeholders but has no "translators:" comment to clarify their meaning. (inc/post-metaboxes.php:183)
  • Warning: The string "%sYou have not set a description for your site.%s Add a site description by visiting %sthe Largo Theme Options page%s." contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-about.php:56)
  • Warning: Multiple placeholders should be ordered. (inc/widgets/largo-about.php:56)
  • Warning: The string "About %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-about.php:103)
  • Warning: The string "%3$s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-follow.php:57)
  • Warning: The string "Follow %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-follow.php:78)
  • Warning: The string "

    You don't have any recent %s.

    " contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-recent-posts.php:109)
  • Warning: The string "Select %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/widgets/largo-taxonomy-list.php:76)
  • Warning: The string "Read All Posts By %s" contains placeholders but has no "translators:" comment to clarify their meaning. (inc/byline_class.php:284)
  • Warning: The string "Monthly Archives: %s" contains placeholders but has no "translators:" comment to clarify their meaning. (archive.php:43)
  • Warning: The string "Yearly Archives: %s" contains placeholders but has no "translators:" comment to clarify their meaning. (archive.php:45)
  • Warning: The string "Search results for %s" contains placeholders but has no "translators:" comment to clarify their meaning. (search.php:12)
  • Warning: The string "Your search for %s returned " contains placeholders but has no "translators:" comment to clarify their meaning. (search.php:103)
  • Warning: The string "Enter the copyright and credit information to display in the footer. You can use %d to output the current year." contains placeholders but has no "translators:" comment to clarify their meaning. (options.php:136)
  • Warning: The string "© Copyright %d, " contains placeholders but has no "translators:" comment to clarify their meaning. (options.php:138)
  • Warning: The string "

    About %2$s

    " contains placeholders but has no "translators:" comment to clarify their meaning. (partials/author-bio-description.php:7)
  • Warning: The string "Apologies, but %s was not found. Perhaps searching will help." contains placeholders but has no "translators:" comment to clarify their meaning. (partials/content-not-found.php:9)
  • Warning: The string "Built with the Largo WordPress Theme from the Institute for Nonprofit News." contains placeholders but has no "translators:" comment to clarify their meaning. (partials/footer-boilerplate.php:26)
  • Warning: Multiple placeholders should be ordered. (partials/footer-boilerplate.php:26)
  • Warning: The string "
  • More by %2$s
    • " contains placeholders but has no "translators:" comment to clarify their meaning. (partials/author-bio-social-links.php:56)
  • Success: POT file successfully generated!
@benlk benlk added type: bug priority: low Nice-to-have in a release. status: needs docs status: needs review type: tech debt For necessary updates because code is old labels Dec 7, 2018
@benlk benlk added this to the 0.6.2 milestone Dec 7, 2018
@benlk
Copy link
Collaborator Author

benlk commented Dec 7, 2018

This can be lumped under the #844 umbrella issue.

@benlk
Copy link
Collaborator Author

benlk commented Aug 22, 2019

This issue may need to be updated from #844.

@benlk
Copy link
Collaborator Author

benlk commented Oct 7, 2019

Since we're now past 0.6.2, anyone wanting to contribute this should:

  1. get set up with a local dev env containing Node.js and wp-cli
  2. run npm i to download Grunt and its dependencies
  3. run grunt pot to regenerate the translation files
  4. make note of any issues, such as the form of the list above
  5. fix the issues.

This was referenced Apr 21, 2020
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted priority: low Nice-to-have in a release. status: needs docs status: needs review type: bug type: tech debt For necessary updates because code is old
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
1 participant
@benlk