Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clean Contact library #1691

Open
joshdarby opened this issue Apr 24, 2019 · 2 comments
Open

Remove Clean Contact library #1691

joshdarby opened this issue Apr 24, 2019 · 2 comments
Labels
category: sunset things we're sunsetting Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: improvement type: tech debt For necessary updates because code is old
Milestone
0.7 - Foundation ...

Comments

@joshdarby
Copy link
Collaborator

While running our theme-check plugin test for the 0.6.2 release, we received this error:

lib/clean-contact/clean_contact.php. Themes should use add_theme_page() for adding admin pages. Line 272: add_submenu_page( 'options-general.php', __( 'Clean Contact', 'largo' )

You can see the full error/warning list on issue #1677.

Let's review the library and see if we're still using it. If so, explore options for keeping and updating it.

If it's unused, let's remove it.
@joshdarby joshdarby added type: improvement priority: normal Must be completed before release of this version of plugin. type: tech debt For necessary updates because code is old labels Apr 24, 2019
@benlk benlk added the category: sunset things we're sunsetting label Aug 21, 2019
@MirandaEcho
Copy link
Collaborator

Review inclusion of Clean Contact library for newsletter signups

@benlk
Copy link
Collaborator

benlk commented Aug 21, 2019

  • remove lib, widgets, styles
  • remove from docs
  • make sure our existing docs for newsletter signups are updated

@joshdarby joshdarby mentioned this issue Aug 22, 2019
Closed
@benlk benlk changed the title Review inclusion of Clean Contact library Remove Clean Contact library Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: sunset things we're sunsetting Estimate: < 2 Hours priority: normal Must be completed before release of this version of plugin. type: improvement type: tech debt For necessary updates because code is old
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
3 participants
@benlk @joshdarby @MirandaEcho