removing duplicate code for navigation toggle on mobile #1286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1166
The code removed here was duplicating the work in L166-215, causing issues on iOS mobile.
To reproduce, use Chrome developer tools device emulation for iPhone and test secondary navigation opens on the main navigation menu.
Previously, on click, the js would both add and remove the
open
class, appearing to do nothing for the end user. This removed the additional code so theopen
class is added and removed where appropriate.